Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove console.log statements, update test, and purge children i… #2959

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

liujuping
Copy link
Collaborator

…n NodeChildren class

@liujuping liujuping requested a review from JackLian as a code owner March 6, 2024 08:39
Copy link

github-actions bot commented Mar 6, 2024

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 34.13% 114/334
🔴 Branches 14.71% 25/170
🔴 Functions 26.74% 23/86
🔴 Lines 34.76% 114/328

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from eb6e80b

Copy link

github-actions bot commented Mar 6, 2024

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements
93.95% (-0.01% 🔻)
2890/3076
🟢 Branches
87.69% (-0.09% 🔻)
1631/1860
🟢 Functions
93.43% (+0.01% 🔼)
868/929
🟢 Lines
94.08% (-0.01% 🔻)
2815/2992
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / node-children.ts
95.74% (-0.37% 🔻)
85.32%
96.72% (+0.05% 🔼)
95.38% (-0.43% 🔻)
🟢
... / setting-top-entry.ts
97.7% (+0.08% 🔼)
86.36% (-8.64% 🔻)
97.78% (+0.05% 🔼)
98.8% (+0.05% 🔼)

Test suite run success

400 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from eb6e80b

Copy link

github-actions bot commented Mar 6, 2024

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 51.03% 421/825
🔴 Branches 50.48% 315/624
🔴 Functions 55.84% 110/197
🔴 Lines 51.2% 406/793

Test suite run success

253 tests passing in 43 suites.

Report generated by 🧪jest coverage report action from eb6e80b

Copy link

github-actions bot commented Mar 6, 2024

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 72.6% 906/1248
🟡 Branches 61.25% 569/929
🟡 Functions 69.78% 194/278
🟡 Lines 72.65% 890/1225

Test suite run success

96 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from eb6e80b

@JackLian JackLian merged commit dc98670 into develop Mar 7, 2024
24 checks passed
@JackLian JackLian deleted the feat/setting-primary-pane branch March 7, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants