Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for great project, here is a little cleanup - because less is more ✨ ✨ ✨
Change Run() to RunT(t) in tests
Goleak found unclosed goroutines in tests, for example
miniredis_test.go:TestDump
never callss.Close()
miniredis/miniredis_test.go
Lines 88 to 129 in 9ac631e
I've changed
Run()
calls toRunT(t)
calls to:There is no risk in using RunT even if test manually closes server
because calling Close multiple times is not an issue.
Move create of client in tests to helper function
Removed duplicated code in tests using helper function.