Skip to content

Commit

Permalink
[Viewer3D] MediaLoader: Bind fixedPointSize for the SfMLoader
Browse files Browse the repository at this point in the history
The `fixedPointSize` parameter was used to determine whether the
point size was fixed or programmable from the QML (using a `PointSize`
render state). With Qt6, this render state is not correctly handled by
the RHI and we need to set directly within the shader whether the point
size is fixed or not, hence the binding.
  • Loading branch information
cbentejac committed Dec 17, 2024
1 parent 9aa9e7f commit e3f1e27
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions meshroom/ui/qml/Viewer3D/MediaLoader.qml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ import Utils 1.0
Component.onCompleted: {
var obj = Viewer3DSettings.sfmDataLoaderComp.createObject(sfmDataLoaderEntity, {
"source": source,
"fixedPointSize": Qt.binding(function() { return Viewer3DSettings.fixedPointSize }),
"pointSize": Qt.binding(function() { return 0.01 * Viewer3DSettings.pointSize }),
"locatorScale": Qt.binding(function() { return Viewer3DSettings.cameraScale }),
"cameraPickingEnabled": Qt.binding(function() { return root.enabled && root.cameraPickingEnabled }),
Expand Down

0 comments on commit e3f1e27

Please sign in to comment.