[BoundingBox] Add visualization for automatically computed bounding box #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarouk
force-pushed
the
dev/bboxMeshing
branch
from
e4660dc to
b01e31b
Compare
fabiencastan
requested changes
Aug 9, 2023
meshroom/core/nodes/__init__.py
Outdated
Comment on lines
3
to
23
| def getNodeClass(nodeType: str): | ||
| """ | ||
| Returns the appropriate subclass of `meshroom.core.node.Node` based on `nodeType`. | ||
|
|
||
| Inputs | ||
| ------ | ||
| nodeType: str | ||
| the name of the node type | ||
|
|
||
| Returns | ||
| ------- | ||
| type[Node] | ||
| the corresponding type class | ||
| """ | ||
| if nodeType=="Meshing": | ||
| from meshroom.core.nodes.MeshingNode import MeshingNode | ||
| cls = MeshingNode | ||
| else: | ||
| from meshroom.core.node import Node | ||
| cls = Node | ||
| return cls |
There was a problem hiding this comment.
The NodeDesc should be able to create a node, with a default implementation that returns "Node".
And then a NodeDesc could override the default Node without having hardcoded node names in the engine.
There was a problem hiding this comment.
Proposed solution (see 87a8376):
- move bounding box update handling to the Meshing node description
- give Node object reference to the corresponding node description
- add a third attribute dictionary in Node (in addition to internal and IO attributes dictionaries) that gives a flexibility to add runtime-related attributes that can be used in qml code
almarouk
force-pushed
the
dev/bboxMeshing
branch
from
b01e31b to
cb4a137
Compare
almarouk
force-pushed
the
dev/bboxMeshing
branch
from
87703a3 to
ce0aa3e
Compare
almarouk
force-pushed
the
dev/bboxMeshing
branch
from
8be718c to
87a8376
Compare
fcastan
force-pushed
the
dev/bboxMeshing
branch
from
87a8376 to
ac4725e
Compare
almarouk
force-pushed
the
dev/bboxMeshing
branch
2 times, most recently
from
9a10a6b to
0992734
Compare
almarouk
force-pushed
the
dev/bboxMeshing
branch
from
0992734 to
44a2a67
Compare
- fix circular dependacy issue in import - fix dirty hack for reading python variable "automaticBBoxValid" in qml
- remove hardcoded nodes information from the code engine - add "runtime attributes" for more flexibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to alicevision/AliceVision#1473