Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] SequencePlayer: minor adjustments (fps, icon, play) #2197

Merged
merged 3 commits into from
Sep 22, 2023
Merged

[ui] SequencePlayer: minor adjustments (fps, icon, play) #2197

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4f130f
[ui] viewer: default value for fps is now 24
fabiencastan Sep 21, 2023
f1c906a
[ui] SequencePlayer: change "repeat" icon
fabiencastan Sep 21, 2023
191663f
[ui] SequencePlayer: play on last frame restart from the beginning
fabiencastan Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions meshroom/ui/qml/Viewer/SequencePlayer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ FloatingPane {
property bool syncSelected: true
property bool playing: false
property bool repeat: false
property real fps: 1
property real fps: 24

onFrameChanged: {
updateReconstructionView();
Expand All @@ -55,7 +55,11 @@ FloatingPane {

onPlayingChanged: {
syncSelected = !playing;
viewer.playback(m.playing);
if(playing && (frame + 1 >= sortedViewIds.length))
{
frame = 0;
}
viewer.playback(playing);
}
}

Expand Down Expand Up @@ -231,6 +235,7 @@ FloatingPane {
from: 1
to: 60
stepSize: 1
value: m.fps

onValueChanged: {
m.fps = value;
Expand All @@ -243,7 +248,7 @@ FloatingPane {

checkable: true
checked: false
text: MaterialIcons.replay
text: MaterialIcons.repeat
ToolTip.text: "Repeat"

onCheckedChanged: {
Expand Down