Add camera color spaces #2251
Merged
Add camera color spaces #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
force-pushed
the
dev/addCameraColorSpaces
branch
from
5d51f1b to
d50c674
Compare
cbentejac
force-pushed
the
dev/addCameraColorSpaces
branch
2 times, most recently
from
23df8f0 to
c0ab8f3
Compare
fabiencastan
approved these changes
Jan 31, 2024
fcastan
force-pushed
the
dev/addCameraColorSpaces
branch
2 times, most recently
from
2663fb8 to
78b5e11
Compare
…th spaces in strings We have the problem of spaces in file paths, choices (like colorspace), etc. An empty list is not send to the command line. An empty string is send to the command line as "". Add new unit test to ensure it follows the expected rules.
fcastan
force-pushed
the
dev/addCameraColorSpaces
branch
from
78b5e11 to
092dcfe
Compare
If the joinChar is NOT space, we use global quotes. If the joinChar is space, we use quotes per element.
…mple expressions
For instance, on the Meshing node "outputMesh" param expression is:
value="{cache}/{nodeType}/{uid0}/mesh.{outputMeshFileTypeValue}",
So the extension here should not contains quotes.
fcastan
force-pushed
the
dev/addCameraColorSpaces
branch
from
71b7c19 to
c6d0933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds native support of the following camera color spaces through an updated "ocio.config" file:
ARRI:
Linear ARRI Wide Gamut_3
ARRI LogC3 (EI800)
Linear ARRI Wide Gamut_4
ARRI LogC4
Black Magic:
Linear BMD Wide Gamut Gen5
BMD Film Wide Gamut Gen5
Canon:
CanonLog2 Cinema Gamut D55
CanonLog3 Cinema Gamut D55
Linear Cinema Gamut D55
Panasonic:
Linear V Gamut
V Log V Gamut
RED:
Linear RED Wide Gamut RGB
Log3G10 RED Wide Gamut RGB
Sony:
Linear Venice S Gamut3 Cine
S Log3 Venice S Gamut3 Cine
Features list
Implementation remarks