-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin System #2407
Open
mh0g
wants to merge
5
commits into
develop
Choose a base branch
from
dev/plugin_system
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Plugin System #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
12 tasks
Just-Kiel
reviewed
Jul 25, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Could it be great to have "Delete Environment" button ? Like the "Delete Data" |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
added in todos for next version. Could be added to the "manage installed plugins" page, alongside the "un-install plugin" button |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mh0g
force-pushed
the
dev/plugin_system
branch
2 times, most recently
from
August 8, 2024 09:56
8a21540
to
61d8a15
Compare
Just-Kiel
reviewed
Aug 23, 2024
mh0g
force-pushed
the
dev/plugin_system
branch
2 times, most recently
from
September 12, 2024 12:36
ea95d40
to
b7f9a2f
Compare
mh0g
force-pushed
the
dev/plugin_system
branch
from
September 16, 2024 17:10
66e7532
to
fab1b8e
Compare
mh0g
force-pushed
the
dev/plugin_system
branch
from
September 30, 2024 13:58
0e26264
to
fa47004
Compare
added back menu after update fix for existing symlink
mh0g
force-pushed
the
dev/plugin_system
branch
from
October 8, 2024 09:11
f98790b
to
24c4585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature adds a plugin system to meshroom.
It also allows to install and run new nodes using containerization tools, such as conda and docker.
Features list
v1
v2
v3
Implementation remarks
The logic is in meshroom/core/plugin.py .
It defines a new node classes to run python code in environments/containers using meshroom_compute.
Added bandit file to not test the shell call errors in codefactor.
Uses the CI en var to skip the tests on CI.
Future needed work: ui part to list/uninstall catalog, multiples envs per node, button to delete env