Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Various minor UI fixes #2563

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[ui] Various minor UI fixes #2563

wants to merge 6 commits into from

Conversation

cbentejac
Copy link
Contributor

Description

This PR contains various minor UI fixes:

  1. The inputFiles parameter in the Publish node is exposed, in order to get a display that's identical to what we had prior to [core/ui] "Exposed" property added to attributeDesc #2528.
  2. Following the introduction of the homepage, the "application" part of Meshroom could not correctly be resized: if the size of the window was changed while the stack view was displaying the application, the content of the view was fitted vertically, but never horizontally. The window is now filled both vertically and horizontally for the application, just as it was for the homepage.
  3. The split view of the homepage that contains all the logos had a minimal size that could lead to all these logos being hidden. The minimal size now is adjusted to ensure that everything is properly fitted.
  4. The condition to highlight output pins was erroneous and always failed in conditions in which it should have succeeded.
  5. Some accesses to the sequence player were made without checking that the sequence player existed in the first place, leading to null accesses (when QtAliceVision is not loaded, for example).
  6. Pins were edited manually when attributes became visible or invisible, thus leading the edges to appear or disappear. Disappearing edges are now handled differently, and the pins do not need to be reset manually, considering that it also causes errors in regular cases.

The content of the application was filling the window's size vertically,
but not horizontally.
When the SequencePlayer isn't available (when QtAliceVision has not been
loaded), the `viewer` element is null. All accesses to properties of this
object should thus be prevented.
Editing the pins manually was useful when trying to hide fully the
connection whenever there was an edge connected to an attribute that
was disabled. Disabled attributes now have a special display if they are
connected, meaning both ends of the edge do not need artificial updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant