Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MultiView Photometric Stereo pipeline and new sfmFilter node #2582

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

jmelou
Copy link
Member

@jmelou jmelou commented Oct 25, 2024

New pipeline for MV-PS.
New sfmFilter node: split sfm based on filenames regex
PR associated with alicevision/AliceVision#1769

@fabiencastan fabiencastan changed the title Dev/sfm filter New sfmFilter node: split sfm based on filenames regex Oct 29, 2024
@fabiencastan fabiencastan added this to the Meshroom 2024.1.0 milestone Oct 29, 2024
@fabiencastan fabiencastan added the feature new feature (proposed as PR or issue planned by dev) label Oct 29, 2024
jmelou and others added 5 commits December 13, 2024 17:09
Select views using regex
Pose transfert in SfMTransfert
The template has been renamed to fit the automatic name parsing of
template files, it has been effectively converted to an actual template
and all the nodes have been aligned coherently.
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.89%. Comparing base (c2d4159) to head (92a4db4).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2582      +/-   ##
===========================================
+ Coverage    69.85%   69.89%   +0.03%     
===========================================
  Files          120      121       +1     
  Lines         7067     7076       +9     
===========================================
+ Hits          4937     4946       +9     
  Misses        2130     2130              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiencastan fabiencastan added majorFeature and removed feature new feature (proposed as PR or issue planned by dev) labels Dec 13, 2024
@fabiencastan fabiencastan changed the title New sfmFilter node: split sfm based on filenames regex New MultiView Photometric Stereo pipeline and new sfmFilter node Dec 13, 2024
Copy link
Member

@fabiencastan fabiencastan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validating for now, but the SfMTransfer needs to be updated to propagate the landmarks with viewId associations.

@fabiencastan fabiencastan merged commit 0aa163d into develop Dec 13, 2024
5 checks passed
@fabiencastan fabiencastan deleted the dev/sfmFilter branch December 13, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants