Removed forced casts on Decoder #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes some forced unwrapping and forced casts on
DecoderIn all cases, the method was returning an optional so this is simple removing the forced unwrapping/casting and returning nil.
There maybe perfectly valid reasons to want the crash to happen in certain circumstances so I completely understand if you decide not to integrate the changes.
In my uses cases, I find it much more preferable to return
nilwhich allows me to catch any error thrown in my code and decide how to handle it.This is a very useful library. Congrats to all involved in this effort.