Update dependencies to stay modern #39
Conversation
| api "androidx.annotation:annotation:1.2.0" | ||
| compileOnly 'io.intercom.android:intercom-sdk-base:10.6.1' | ||
| api "androidx.annotation:annotation:$rootProject.ext.annotationsVersion" | ||
| compileOnly 'io.intercom.android:intercom-sdk-base:12.0.0' |
There was a problem hiding this comment.
There is a newer version of the Intercom SDK available, but updating to the latest version will require updating more test code than I was willing to touch in this PR. Let's update this SDK version in a follow-up PR.
| api "androidx.annotation:annotation:1.2.0" | ||
| compileOnly 'com.kissmetrics.sdk:KISSmetricsSDK:2.3.1' | ||
| api "androidx.annotation:annotation:$rootProject.ext.annotationsVersion" | ||
| // compileOnly 'com.kissmetrics.sdk:KISSmetricsSDK:2.3.1' // Not working |
There was a problem hiding this comment.
The latest versions of the KISSmetrics SDK were on jcenter() which has been sunsetted. As a temporary (I hope 🤞 ) workaround I forked their SDK repo and made it so Jitpack could build the latest version.
There was a problem hiding this comment.
That's too bad.
Is their library deprecated? Or they just haven't gotten around to moving it?
There was a problem hiding this comment.
It seems like they haven't paid much attention to their SDK if they haven't made the time to migrate to a different public repository. I raised a PR in case they want to be able to use Jitpack to build their binaries. 🤷♂️
| compileOnly 'com.google.android.gms:play-services-analytics:17.0.0' | ||
|
|
||
| testImplementation 'com.google.android.gms:play-services-analytics:17.0.0' |
There was a problem hiding this comment.
There is a newer version of the Google Analytics SDK too, but I think there were some breaking changes and I would have had to conform to different function signatures. Let's update to the latest SDK in a follow-up PR.
| api "androidx.annotation:annotation:1.2.0" | ||
| compileOnly 'com.kissmetrics.sdk:KISSmetricsSDK:2.3.1' | ||
| api "androidx.annotation:annotation:$rootProject.ext.annotationsVersion" | ||
| // compileOnly 'com.kissmetrics.sdk:KISSmetricsSDK:2.3.1' // Not working |
There was a problem hiding this comment.
That's too bad.
Is their library deprecated? Or they just haven't gotten around to moving it?
Highlights: