feature: add interactive-mode SQLExecutor with SQLRTTask #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wenyu.ywm seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
fetchadd
requested changes
Jul 19, 2024
| } | ||
|
|
||
| func (t *TaskConfig) AddProperty(key, value string) { | ||
| t.Config = append(t.Config, common.Property{Name: key, Value: value}) | ||
| } | ||
|
|
||
| type BaseTask struct { |
There was a problem hiding this comment.
暂时只有SQLRTTTask用了BaseTask, 先不单独提取一个“父类”。及时提取的话，要对外不可见
| } | ||
|
|
||
| // UpdateInfo set information to running instance | ||
| func (instance *Instance) UpdateInfo(taskName, infoKey, infoValue string) (UpdateInfoResult, error) { |
There was a problem hiding this comment.
和java sdk保持一致，用SetTaskInfo作为方法名
| } | ||
|
|
||
| // UpdateInfo set information to running instance | ||
| func (instance *Instance) UpdateInfo(taskName, infoKey, infoValue string) (UpdateInfoResult, error) { |
There was a problem hiding this comment.
UpdateInfoResult等返回值统一放到instance_res.go里
| return nil | ||
| }, | ||
| ) | ||
| // |
| ) | ||
|
|
||
| const ( | ||
| DEFAULT_TASK_NAME = "sqlrt_task" |
| if err != nil { | ||
| return nil, errors.WithStack(err) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
这个地方为什么在cfg.QueryId != -1时去掉 session.newInitionRequst等逻辑
There was a problem hiding this comment.
这个是不是需要调用： AttachToExistedIRDownloadSession
| aliAccount := account.NewAliyunAccount(conf.AccessId, conf.AccessKey) | ||
| odpsIns := odps.NewOdps(aliAccount, conf.Endpoint) | ||
| odpsIns.SetDefaultProjectName(conf.ProjectName) | ||
| sql := `select * from all_types_demo_no_parition;` |
There was a problem hiding this comment.
例子中的表名用：all_types_demo，需要其他表的话表名DDL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.