Merge pull request #37 from alkem-io/develop

Ack strategy patch
alkem-io · Nov 11, 2021 · f920cb1 · f920cb1
2 parents 2b73b47 + e32e872
commit f920cb1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "alkemio-notifications",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "Alkemio notifications service",
   "author": "Cherrytwist Foundation",
   "private": false,

diff --git a/src/app.controller.ts b/src/app.controller.ts
@@ -40,11 +40,16 @@ export class AppController {
 
         if (nacked.length === 0) {
           this.logger.verbose?.(`All ${x.length} messages successfully sent!`);
+          channel.ack(originalMsg);
         } else {
           this.logger.verbose?.(`${nacked.length} messages failed to be sent!`);
+          //channel.nack(originalMsg);
+          channel.ack(originalMsg);
         }
       })
       .catch(err => {
+        //channel.reject(originalMsg);
+        channel.ack(originalMsg);
         this.logger.error(err);
       });
   }