SimpleCache removed #421
Draft
SimpleCache removed #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozjan
force-pushed
the
simplecache-removed
branch
from
8401114 to
18776e1
Compare
kozjan
force-pushed
the
simplecache-removed
branch
from
79ded11 to
6908643
Compare
druminski
previously approved these changes
Jun 26, 2024
kozjan
force-pushed
the
simplecache-removed
branch
from
6908643 to
bfc965b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to java-control-plane 1.0.45 with SimpleCache removed.
Removed SimpleCache class, which was a copy of envoyproxy's class.
It had custom stuff - shouldSendMissingEndpoints, it's used here and here.
Now the same stuff happens in envoyproxy - there is a
allowDefaultEdsUpdateboolean which setsallowDefaultResourceto true. Then during creating a response resources are mapped using defaultResource, which does pretty much the same mapping as our custom one but with additional check if resource type is ENDPOINT (compared to this).OutlierDetectionTest breaks when Envoy v1.28.0+ is used.