Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified limits for urllib3 library #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jday1
Copy link
Contributor

@jday1 jday1 commented Oct 27, 2023

@jkhenning
Copy link
Member

Hi @jday1, what's the reason for this update? In general, we try not to enforce specific versions and specify the minimum required versions, in order to allow users more flexibility

@jday1
Copy link
Contributor Author

jday1 commented Nov 21, 2023

Hi Jake,

This PR widens the allowed versions of the urllib library in keeping with ClearML's approach.

In my use case, I have libraries which I cannot upgrade cleanly as they require urllib>=2. Hence, I have raised this PR.

Cheers,
James

@jkhenning
Copy link
Member

I'm wondering is there are any breaking changes or things that might cause issues if we use newer versions

@jday1
Copy link
Contributor Author

jday1 commented Dec 5, 2023

I would not expect breaking changes but you could create a release candidate which users (including myself) could test out?

@jkhenning
Copy link
Member

See the migration guide: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
At first glance, it seems that the minimum thing to do is make sure this new constraint is only applied to python 3.7 and up (and keep the old constraint for lower versions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants