Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added tailscale support #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

prassanna-ravishankar
Copy link

@prassanna-ravishankar prassanna-ravishankar commented Feb 21, 2024

PR descriptionm

Background

Networks that use tailscale have their interface specified in tailscale<vpn-id> like tailscale0 or tailscale1 etc.

By default, the hostname that is picked up by the interactive session is of the local lan interface (or the public ip interface). Technically this doesn't matter, as the ssh session is actually alive, and the cli only points to the wrong address. So even if the interactive session via the cli fails, one could always ssh into the session using the ssh and replacing the target IP stored in the clearml task, by the actual tailscale IP address. But for this one needs to do some digging and look into the clearml task to find out which host the session was launched it

Changes proposed

This PR makes the change of broadcasting the tailscale IP into the task configuration if the --tailscale option is given.

Implementation

  • Expose --tailscale as an argument in the CLI
  • If it is activated, cycle through network interfaces to identify the first tailscale interface
  • Identify the ip address broadcasted by this interface
  • Update this information in the task parameters, and ignore the steps of looking for a public ip as earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant