ISSITES-5869 add page size for pagination, sort and search functionality #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 27, 2022 17:08
|
ci:test:sf |
|
Closing pull request because pulls for reference marketplace_poc_rebase should not be sent to repository liferay-portal |
allen-ziegenfus
requested changes
Jan 7, 2023
| } | ||
|
|
||
| .table .column-name:hover:after { | ||
| content: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' class='lexicon-icon lexicon-icon-order-arrow' height='12' width='12' role='presentation' viewBox='0 0 512 512'%3E%3Cpath class='lexicon-icon-outline order-arrow-arrow-down' d='M307.6,431.5l71.6,71.6c11.9,10.8,32.9,11.2,45.8,0l71.6-71.6c29.8-33.6-15.8-74.9-45.8-45.8l-16.7,16.7V31.6c0-42.5-64-42.5-64,0v370.8l-16.7-16.7C321.6,355.8,277.9,400.6,307.6,431.5z' fill='%23999AA3'%3E%3C/path%3E%3Cpath class='lexicon-icon-outline order-arrow-arrow-up' d='M204.4,80.5L132.8,8.9C120.9-1.8,99.9-2.3,87,8.9L15.4,80.5c-29.8,33.6,15.7,74.9,45.8,45.8l16.7-16.7v370.8c0,42.5,64,42.5,64,0V109.6l16.7,16.7C190.4,156.2,234.1,111.4,204.4,80.5z' fill='%23999AA3'%3E%3C/path%3E%3C/svg%3E"); |
There was a problem hiding this comment.
I find these always hard to read - is there a way we could just use a regular svg in markup instead of this?
| @@ -0,0 +1,84 @@ | |||
| /** | |||
There was a problem hiding this comment.
this file isn't formatted correctly - always tabs not spaces!
| <div class="spinner-border text-primary" role="status"> | ||
| <span class="sr-only">Loading...</span> | ||
| </div> | ||
| <ClayLoadingIndicator displayType="primary" shape="squares" size="lg" /> | ||
|
|
||
| <div> | ||
| Hang tight, we are preparing your arrival as publisher and |
There was a problem hiding this comment.
can you add language keys for these text snippets?
| @@ -16,21 +16,23 @@ import {useQuery} from 'react-query'; | |||
|
|
|||
| import fetchProducts from '../queries/fetchProducts'; | |||
|
|
|||
| const getProducts = (_, languageId, page) => { | |||
| const getProducts = (_, languageId, page, pageSize, sort, search) => { | |||
There was a problem hiding this comment.
can you please sort the parameters
| return <th key={accessor}>{label}</th>; | ||
| if (sort.includes(accessor)) { | ||
| if (order) { | ||
| return <th className="column-name" data-category={accessor} key={accessor} onClick={handleSortClick}>{label} <svg class="lexicon-icon lexicon-icon-order-arrow-up" focusable="false" role="presentation"><use xlinkHref="/o/admin-theme/images/clay/icons.svg#order-arrow-up" /></svg></th>; |
There was a problem hiding this comment.
can you simplify this? it looks like almost the same markup twice
| @@ -16,85 +32,122 @@ const Table = () => { | |||
| const publisherName = 'Acme Co'; | |||
| const [languageId] = useState(Liferay.ThemeDisplay.getLanguageId()); | |||
| const [page, setPage] = useState(1); | |||
| const [delta, setDelta] = useState(10); | |||
There was a problem hiding this comment.
can we sort these please?
|
I deployed this to https://marketplace-uat.lxc.liferay.com/dashboard I noticed a few things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.