Run format scripts on workspaces directory #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @allen-ziegenfus!
I added support for running our lint and format scripts via npx.
The two commands I run are
And then followed by
The first script will also generate error messages for items that we can't auto-fix. Some of the warnings you can probably ignore, such as
@liferay/portal/no-global-fetch
since workspaces doesn't have access to frontend-js-web.I wasn't able to get this working in our
ant format-source
tasks, so I think the best way to do this is just manually run it for now.Let me know if you have any issues.
Here is the output of eslint non-fixable errors