-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normal baselines #618
base: main
Are you sure you want to change the base?
Normal baselines #618
Conversation
--fsdp.sharding_strategy=SHARD_GRAD_OP \ | ||
--save_folder=runs/ \ | ||
--device_train_microbatch_size=4 \ | ||
--global_train_batch_size=512 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the default in the config, right?
--global_train_batch_size=512 \ |
--save_folder=runs/ \ | ||
--activation_checkpointing=fine_grained \ | ||
--device_train_microbatch_size=2 \ | ||
--global_train_batch_size=1024 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
--global_train_batch_size=1024 \ |
--wandb.group=$EXPERIMENT \ | ||
--fsdp.wrapping_strategy=by_block_and_size \ | ||
--fsdp.sharding_strategy=SHARD_GRAD_OP \ | ||
--save_folder=runs/ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think there's any need to override this
--save_folder=runs/ \ |
--wandb.group=$EXPERIMENT \ | ||
--fsdp.wrapping_strategy=by_block_and_size \ | ||
--fsdp.sharding_strategy=SHARD_GRAD_OP \ | ||
--save_folder=runs/ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I don't think there's any need to override this
--save_folder=runs/ \ |
Llamaish setup with the following config: