Removing Collider-Based visibility scheme option
#1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit removes all references and use of the collider based visibility scheme used to query sim objects from cameras. Moving forward this scheme will not be supported, and all visibility checks will now be completely distance-based from the camera (ie: objects will only be potentially visible if they are within maxVisibleDistance from the camera based purely by raycast distance) Additionally, updating the function to query objects from a camera to be called `GetVisibleObjectsFromCamera` since the old name `GetVisibleObjects` was too easily confused with other object-visibility helper functions. The old`GetVisibleObjects` action will remain but will have a deprecation warning message thrown for those who may still use it. Finally, added unit tests for`GetVisibleObjectsFromCamera`
|
Ok one request, can you throw an exception on LGTM after that |
elimvb
reviewed
Aug 19, 2024
Lucaweihs
requested changes
Aug 20, 2024
... to ensure an error is thrown because the local visibilityScheme value is set to the only valid enum at initialization now also adding a main camera unit test in GetVisibleObjectsFromCamera as previously only the created ThirdPartyCamera was being tested for expected returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all references and use of the collider based visibility scheme used to query sim objects from cameras. Moving forward this scheme will not be supported, and all visibility checks will now be completely distance-based from the camera (ie: objects will only be potentially visible if they are within maxVisibleDistance from the camera based purely by raycast distance)
Additionally, updating the function to query objects from a camera to be called
GetVisibleObjectsFromCamerasince the old nameGetVisibleObjectswas too easily confused with other object-visibility helper functions. The oldGetVisibleObjectsaction will remain but will have a deprecation warning message thrown for those who may still use it.Finally, added unit tests for
GetVisibleObjectsFromCamera