Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the option to run on a whole document at a time #4

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Conversation

dirkgr
Copy link
Member

@dirkgr dirkgr commented Apr 12, 2023

Other changes:

  • Annotations are now in the fields "bff_duplicate_spans" and "bff_contained_ngram_count". Those names have changed.
  • bff will always create the "bff_contained_ngram_count" field, even when running deduplication.

@dirkgr dirkgr requested a review from IanMagnusson April 12, 2023 20:02
@dirkgr
Copy link
Member Author

dirkgr commented Apr 12, 2023

To be sure, I don't know what the point of this is. It would be insane to run deduplication this way. It would be borderline insane to even count ngrams this way (i.e., with --annotate-only). And it's not implementing the full GPT2 spec from #3 either, which is already insane all by itself.

So I'm just writing the code and I trust that you know what you're doing with it.

Copy link
Contributor

@IanMagnusson IanMagnusson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! For posterity, we sorted out the two issues: 1) fixing the update bloom filter flag so it actually works, 2) using filter threshold of 1.0 when priming the bloom filter to make sure all ngrams are included without any skipping.

@dirkgr dirkgr merged commit 2fc2e49 into main Apr 25, 2023
@dirkgr dirkgr deleted the WholeDocument branch April 25, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants