Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ff #36

Merged
merged 7 commits into from
Aug 27, 2023
Merged

ff #36

merged 7 commits into from
Aug 27, 2023

Commits on Aug 22, 2023

  1. add make test 

    add `make test` target into Makefile that tests both rust and python
    @chris-ha458
    chris-ha458 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    6a2e479 View commit details
    Browse the repository at this point in the history

  2. hacky skip rust tests 

    skip s3 related rust tests if
DOLMA_TESTS_SKIP_AWS=True
    @chris-ha458
    chris-ha458 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d116148 View commit details
    Browse the repository at this point in the history

  3. add documentation for test skips

    @chris-ha458
    chris-ha458 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e10ab15 View commit details
    Browse the repository at this point in the history

  4. improve docs

    @chris-ha458
    chris-ha458 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    530b4c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. style fixes

    @chris-ha458
    chris-ha458 committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    cc4c3d5 View commit details
    Browse the repository at this point in the history

  2. better var retrieval 

    make it simpler and clearer what we're trying to do.
No need to set to false since we arent going to do anything unless `var==true`
    @chris-ha458
    chris-ha458 committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    3b65668 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Merge pull request #31 from chris-ha458/fix_make_more 

    Fix `make` more
    @soldni
    soldni authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    8d6ddfe View commit details
    Browse the repository at this point in the history