Proposal: Add support for function arguments to be passed in the same line as the function

[srtfisher]

Allows multi-line function calls to support passing arguments on the same line as the function name. For example, this is now valid code:

ai_method_call( [
	'foo' => 'bar',
] );

Previously had to only write this as (still supported though):

ai_method_call(
	[
		'foo' => 'bar',
	]
);

Disables the PEAR.Functions.FunctionCallSignature sniff entirely and replaces it with PSR2.Methods.FunctionCallSignature.

[kingkool68]

Not a strong opinion here but for something as short as one line of arguments I would do

ai_method_call( [ 'foo' => 'bar' ] );

so not sure I would ever do

ai_method_call( [
	'foo' => 'bar',
] );

and

ai_method_call( [
	'foo' => 'bar',
    'baz' => 'bam',
] );

would be illegal so I don't really see the point

[srtfisher]

I would and have done this previously and ignored the rule:

ai_method_call( [
	'foo' => 'bar',
], true );

or more likely

ai_method_call( [
	'foo' => 'bar',
	'foo2' => 'bar',
	'foo3' => 'bar',
	'foo4' => 'bar',
] );

Your example wouldn't be illegal -- it'd be what I'm suggesting to make it.

[mogmarsh]

I have run into this occasionally, but always just fix it rather than ignore it. I think sometimes this will be more readable, sometimes not... we'll trust the dev and/or the reviewer to figure that out. This gives us options.
👍