Merge pull request #1195 from alleyinteractive/fix/APPLE-193/cover-ph…

…oto-show-caption Enable caption on the Cover component by default
alleyinteractive · Nov 19, 2024 · f36ff4e · f36ff4e
2 parents 6eedc79 + 69ffe36
commit f36ff4e
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 1 deletion.
diff --git a/assets/themes/classic.json b/assets/themes/classic.json
@@ -44,6 +44,7 @@
     "caption_line_height": 19,
     "caption_size": 14,
     "caption_tracking": -1,
+    "cover_caption": true,
     "cite_color": "#333333",
     "cite_font": "Helvetica-Bold",
     "cite_line_height": 19,

diff --git a/assets/themes/colorful.json b/assets/themes/colorful.json
@@ -44,6 +44,7 @@
     "caption_line_height": 22,
     "caption_size": 14,
     "caption_tracking": -3,
+    "cover_caption": true,
     "cite_color": "#3045ca",
     "cite_font": "Georgia",
     "cite_line_height": 22,

diff --git a/assets/themes/dark.json b/assets/themes/dark.json
@@ -44,6 +44,7 @@
     "caption_line_height": 19,
     "caption_size": 14,
     "caption_tracking": -1,
+    "cover_caption": true,
     "cite_color": "#999999",
     "cite_font": "Helvetica-Light",
     "cite_line_height": 19,

diff --git a/assets/themes/default.json b/assets/themes/default.json
@@ -44,6 +44,7 @@
     "caption_line_height": 24,
     "caption_size": 16,
     "caption_tracking": 0,
+    "cover_caption": true,
     "cite_color": "#4f4f4f",
     "cite_font": "AvenirNext-Italic",
     "cite_line_height": 24,

diff --git a/assets/themes/modern.json b/assets/themes/modern.json
@@ -44,6 +44,7 @@
     "caption_line_height": 17,
     "caption_size": 14,
     "caption_tracking": 0,
+    "cover_caption": true,
     "cite_color": "#000000",
     "cite_font": "AvenirNext-DemiBold",
     "cite_line_height": 17,

diff --git a/assets/themes/pastel.json b/assets/themes/pastel.json
@@ -44,6 +44,7 @@
     "caption_line_height": 19,
     "caption_size": 14,
     "caption_tracking": -1,
+    "cover_caption": true,
     "cite_color": "#333333",
     "cite_font": "AvenirNext-Regular",
     "cite_line_height": 19,

diff --git a/includes/apple-exporter/class-theme.php b/includes/apple-exporter/class-theme.php
@@ -886,7 +886,7 @@ private static function initialize_options() {
 				'type'        => 'integer',
 			],
 			'cover_caption'                      => [
-				'default' => false,
+				'default' => true,
 				'label'   => __( 'Enable caption on the Cover component', 'apple-news' ),
 				'type'    => 'boolean',
 			],