Issue-1154: A different approach to reindex the deleted article #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatonascalves
commented
Oct 11, 2024
| @@ -52,16 +52,7 @@ public function perform() { | |||
| } | |||
|
|
|||
| // Get the article from the API. | |||
| try { | |||
There was a problem hiding this comment.
I removed this so that we keep the data removal intentional. Since GET requests are performed in more unrelated places than I anticipated.
renatonascalves
deleted the
feature/feature/issue-1154/support-handling-deleted-articles-second-approach
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup from #1176
See #1154
The new approach makes sure it works for both the classic editor and the block editor.