Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues with CI #5

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Address issues with CI #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3469fd
Update minimum supported WordPress version and tested version
attackant Mar 12, 2024
4ad43d4
Ignore PHPCS warnings for non-prefixed hooknames because Buddy isn't …
attackant Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<exclude-pattern>vendor/</exclude-pattern>

<!-- The version set here matches the minimum version tested in buddy.yml. -->
<config name="minimum_supported_wp_version" value="6.4" />
<config name="minimum_supported_wp_version" value="6.3" />

<!-- Define the prefixes that can be used by the plugin -->
<rule ref="WordPress.NamingConventions.PrefixAllGlobals">
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ A WordPress plugin to provide full page caching for 404 pages, improving perform
## Requirements
- SSL enabled on the website.
- An external object cache setup (e.g., Redis, Memcached).
- Requires at least: 6.4
- Tested up to: 6.5
- Requires at least: 6.3
- Tested up to: 6.4
- Requires PHP: 8.1
- License: GPL v2 or later

Expand Down
4 changes: 2 additions & 2 deletions src/features/class-full-page-cache-404.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ final class Full_Page_Cache_404 implements Feature {
* @return int
*/
public static function get_cache_time(): int {
return apply_filters( 'wp_404_caching_cache_time', self::DEFAULT_CACHE_TIME );
return apply_filters( 'wp_404_caching_cache_time', self::DEFAULT_CACHE_TIME ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
}

/**
Expand All @@ -82,7 +82,7 @@ public static function get_cache_time(): int {
* @return int
*/
public static function get_stale_cache_time(): int {
return apply_filters( 'wp_404_caching_stale_cache_time', self::DEFAULT_STALE_CACHE_TIME );
return apply_filters( 'wp_404_caching_stale_cache_time', self::DEFAULT_STALE_CACHE_TIME ); // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound
}

/**
Expand Down
4 changes: 2 additions & 2 deletions wp-404-caching.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
* Version: 1.0.1
* Author: Alley
* Author URI: https://github.com/alleyinteractive/wp-404-caching
* Requires at least: 6.4
* Tested up to: 6.5
* Requires at least: 6.3
* Tested up to: 6.4
*
* Text Domain: wp-404-caching
* Domain Path: /languages/
Expand Down