Add initial functionality and tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montchr
approved these changes
May 26, 2022
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| php: [8.1] |
There was a problem hiding this comment.
To my knowledge, Composer config validation depend on the PHP version.
There was a problem hiding this comment.
Gah: Composer config validation doesn't depend on the PHP version
| MYSQL_ALLOW_EMPTY_PASSWORD: yes | ||
| ports: | ||
| - 3306:3306 | ||
| options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 |
There was a problem hiding this comment.
Suggested change
| options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 | |
| options: | | |
| --health-cmd="mysqladmin ping" \ | |
| --health-interval=10s \ | |
| --health-timeout=5s \ | |
| --health-retries=3 |
Comment on lines
+2
to
+10
| /** | ||
| * Class file for Noop | ||
| * | ||
| * (c) Alley <[email protected]> | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| * | ||
| * @package wp-find-one |
There was a problem hiding this comment.
Suggested change
| /** | |
| * Class file for Noop | |
| * | |
| * (c) Alley <[email protected]> | |
| * | |
| * For the full copyright and license information, please view the LICENSE | |
| * file that was distributed with this source code. | |
| * | |
| * @package wp-find-one | |
| /** | |
| * Class file for Noop | |
| * | |
| * Copyright (c) 2022, Alley and the Find One contributors | |
| * SPDX-License-Identifier: GPL-2.0-or-later | |
| * | |
| * For the full copyright and license information, please view the LICENSE | |
| * file that was distributed with this source code. | |
| * | |
| * @package wp-find-one |
Comment on lines
+5
to
+6
| * (c) Alley <[email protected]> | ||
| * |
There was a problem hiding this comment.
Suggested change
| * (c) Alley <[email protected]> | |
| * | |
| * Copyright (c) 2022, Alley and the Find One contributors | |
| * SPDX-License-Identifier: GPL-2.0-or-later | |
| * |
Comment on lines
+5
to
+6
| * (c) Alley <[email protected]> | ||
| * |
There was a problem hiding this comment.
Suggested change
| * (c) Alley <[email protected]> | |
| * | |
| * Copyright (c) 2022, Alley and the Find One contributors | |
| * SPDX-License-Identifier: GPL-2.0-or-later | |
| * |
Comment on lines
+5
to
+6
| * (c) Alley <[email protected]> | ||
| * |
There was a problem hiding this comment.
Suggested change
| * (c) Alley <[email protected]> | |
| * | |
| * Copyright (c) 2022, Alley and the Find One contributors | |
| * SPDX-License-Identifier: GPL-2.0-or-later | |
| * |
Co-authored-by: Chris Montgomery <[email protected]>
|
I'm going to proceed knowing that the question of documenting the license is unresolved (here and on other repos). @montchr, please feel free to open issues here in GitHub for anything else you'd like to discuss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As titled.
Notes for reviewers
Tests are expected to fail on multisite runs pending the next release of https://github.com/mantle-framework/testkit.
Changelog entries
Added
Changed
Deprecated
Removed
Fixed
Security