Add IntMap methodmap #2018
Merged
Add IntMap methodmap #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a continuation of alliedmodders#579. [HashMap] Adds new IntHashMap and IntMap natives. This patch makes the following changes * Refactors StringHashMap to a generic HashMap template * Adds the IntHashMap class * Adds new IntMap natives * Adds IntMap tests to the tries test suite [HashMap] Reverted rename of CharsAndLength [HashMap] Use more descriptive template names [HashMap] Removed old-style natives [HashMap] Removed IntHash class [HashMap] Reverted some search & replace errors Co-authored-by: Geoffrey McRae <[email protected]>
Headline
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Hey, cool. Thanks for picking this up.This looks good to take in.
@peace-maker can you give this a look? Seems to me this covers everything
|
Ah sorry, this fell off the stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #579. In addition to taking the PR comments into account, this also adds
IntMap.ContainsKeyandIntMap.Cloneand updates the tests. Both theStringMapandIntMaptests pass.Some other notes:
CellTrietoStringCellTrieandTrieSnapshottoStringTrieSnapshotfor review purposes, but I can change it if requested.Original PR message: