Support ASAN option for Windows #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvander
approved these changes
Jan 22, 2022
| if cxx.target.platform == 'windows': | ||
| cxx.cflags += ['/fsanitize=address'] | ||
| return | ||
| elif cxx.target.platform != 'linux': |
There was a problem hiding this comment.
nit: no need for "elif" here, "if" will suffice
There was a problem hiding this comment.
@Headline looks like this has been pending for 2 years - is this the only blocker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a lot less work than what we had to do for clang, we just have to check msvc version