Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11 handle z7string for cells_for_geo_points #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#11 handle z7string for cells_for_geo_points #12

wants to merge 1 commit into from

Conversation

tik65536
Copy link
Contributor 

- change output file name of output_conf prefix with {output_address_type}
- supply dtype to pd.read_csv if output_address_type contains "STRING" (otherwise it will auto convert to int64)
- change the cells_id column to "name" in the return df. Align with other's functions.
- update parameters when calling grid_cell_polygons_from_cellids with
  a. input_address_type=output_address_type
  b. output_address_type=output_address_type

@tik65536
allixender#11 handle z7string for cells_for_geo_points
c668342 
    - change output file name of output_conf
      prefix with {output_address_type}
    - supply dtype to pd.read_csv if output_address_type
      contains "STRING" (otherwise it will auto convert to int64)
    - change the cells_id column to "name" in the return df.
      Align with other's functions.
    - update parameters when calling grid_cell_polygons_from_cellids
      with
       a. input_address_type=output_address_type
       b. output_address_type=output_address_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tik65536