Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: registry unit tests #657

Merged
merged 7 commits into from
Sep 10, 2024
Merged

test: registry unit tests #657

merged 7 commits into from
Sep 10, 2024

Conversation

0xOneTony
Copy link

No description provided.

0xAustrian
0xAustrian reviewed Sep 5, 2024
View reviewed changes
Copy link

@0xAustrian 0xAustrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see a few missing tests or skipped, why is that?

test/unit/core/RegistryUnit.t.sol Show resolved Hide resolved
test/unit/core/RegistryUnit.tree Show resolved Hide resolved
@0xOneTony 0xOneTony marked this pull request as ready for review September 5, 2024 14:24
@0xOneTony 0xOneTony merged commit d52f4a2 into v2.1 Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilpepepig ilpepepig ilpepepig approved these changes

@0xAustrian 0xAustrian 0xAustrian approved these changes

@thelostone-mc thelostone-mc thelostone-mc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xOneTony @thelostone-mc @0xAustrian @ilpepepig