Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add strategies deployment script #658

Closed
wants to merge 7 commits into from

Conversation

0xAustrian
Copy link

Closes DTT-296

@0xAustrian 0xAustrian self-assigned this Sep 4, 2024
Copy link

linear bot commented Sep 4, 2024

Copy link

@0xOneTony 0xOneTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one minor comment

import {DirectAllocationStrategy} from "contracts/strategies/examples/direct-allocation/DirectAllocation.sol";

contract DeployDirectAllocation is DeployBase {
function _deploy() internal override returns (address _contract) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to also have a log of the name of the strategy we deploy

@0xOneTony 0xOneTony marked this pull request as ready for review September 11, 2024 09:53
@0xOneTony 0xOneTony closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants