Add support for new events introduced at v0.6.3 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandofcampos
force-pushed
the
PROTO-2723
branch
2 times, most recently
from
69a9ed8
to
89894ec
Compare
kpeluso
approved these changes
Nov 8, 2024
fernandofcampos
force-pushed
the
PROTO-2723
branch
2 times, most recently
from
f581e52
to
295bd08
Compare
kpeluso
approved these changes
Nov 8, 2024
| return insertNetworkRegret(events, TB_NAIVE_INFERER_NETWORK_REGRET) | ||
| } | ||
|
|
||
| func insertTopicInitialRegret(events []EventRecord) error { |
There was a problem hiding this comment.
later we could explore adding a generic function to abstract some of this out
fernandofcampos
force-pushed
the
PROTO-2723
branch
from
295bd08
to
27b6382
Compare
fernandofcampos
changed the title
kpeluso
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
Link(s) to Ticket(s) or Issue(s) resolved by this PR
Are these changes tested and documented?
Unreleasedsection ofCHANGELOG.md?Still Left Todo
Fill this out if this is a Draft PR so others can help.