-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
build image workflow
fix mistake for docker file path
* finalize docker image build * update to latest blockless for cgi support
* Use `dev.3` release asset id to pass params to py function
adds an easy way to debug using vscode play functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Mostly small things.
Obvi having this in WASM is ideal, but for what you set out to do / as a stepping stone, it's directionally ok.
cmd/node/appchain.go
Outdated
return 0, err | ||
} | ||
|
||
return result.Ethereum["usd"], nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in testing, you should be sure to check the units and decimals of the model. it's likely 0 decimals, a float, and usd, I don't know that with 100% certainty tho
cmd/node/appchain.go
Outdated
|
||
// Get lastest weight of each peer/worker | ||
var workerLatestWeights map[string]float64 = make(map[string]float64) | ||
for _, p := range workersPredictions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note for v2: figure out how to do this in bulk
cmd/node/appchain.go
Outdated
// Calculate the loss for each worker | ||
losses := make(map[string]float64) | ||
var scores []float64 | ||
for _, prediction := range workersPredictions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least for v2, add validation. it's an adversarial environment.
Oh, also recall that for the correct implementation, we want to decouple weight adjustment from inference collection. for v0.1 I could go either way on this, but decoupled is the ideal |
I think we can close this right? Most things have been included in the main, and I have a PR open for fluff. @guilherme-brandao ? |
No description provided.