Remove serde feature from rpc-types-any

alloy-rs · Nov 14, 2024 · ea7e1f3 · ea7e1f3
1 parent da79415
commit ea7e1f3
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 11 deletions.
diff --git a/crates/network/Cargo.toml b/crates/network/Cargo.toml
@@ -25,7 +25,7 @@ alloy-eips = { workspace = true, features = ["serde"] }
 alloy-json-rpc.workspace = true
 alloy-network-primitives.workspace = true
 alloy-primitives = { workspace = true, features = ["map"] }
-alloy-rpc-types-any = { workspace = true, features = ["serde"] }
+alloy-rpc-types-any.workspace = true
 alloy-rpc-types-eth = { workspace = true, features = ["std", "serde"] }
 alloy-signer.workspace = true
 alloy-serde.workspace = true

diff --git a/crates/rpc-types-any/Cargo.toml b/crates/rpc-types-any/Cargo.toml
@@ -19,15 +19,12 @@ rustdoc-args = ["--cfg", "docsrs"]
 workspace = true
 
 [dependencies]
-alloy-consensus-any = { workspace = true, optional = true }
+alloy-consensus-any = { workspace = true, features = ["serde"] }
 alloy-rpc-types-eth.workspace = true
-alloy-serde = { workspace = true, optional = true }
+alloy-serde.workspace = true
 
 [dev-dependencies]
 alloy-primitives.workspace = true
 
 serde.workspace = true
 serde_json.workspace = true
-
-[features]
-serde = ["dep:alloy-serde", "alloy-consensus-any/serde"]
diff --git a/crates/rpc-types-any/src/lib.rs b/crates/rpc-types-any/src/lib.rs
@@ -7,7 +7,6 @@
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 mod transaction;
-#[cfg(feature = "serde")]
 pub use transaction::AnyTransactionReceipt;
 
 mod block;

diff --git a/crates/rpc-types-any/src/transaction/mod.rs b/crates/rpc-types-any/src/transaction/mod.rs
@@ -1,3 +1,2 @@
 mod receipt;
-#[cfg(feature = "serde")]
 pub use receipt::AnyTransactionReceipt;
diff --git a/crates/rpc-types-any/src/transaction/receipt.rs b/crates/rpc-types-any/src/transaction/receipt.rs
@@ -2,7 +2,6 @@ use alloy_rpc_types_eth::{Log, TransactionReceipt};
 
 /// Alias for a catch-all receipt type.
 #[doc(alias = "AnyTxReceipt")]
-#[cfg(feature = "serde")]
 pub type AnyTransactionReceipt =
     alloy_serde::WithOtherFields<TransactionReceipt<alloy_consensus_any::AnyReceiptEnvelope<Log>>>;
 
@@ -12,7 +11,6 @@ mod test {
     use alloy_primitives::b256;
 
     #[test]
-    #[cfg(feature = "serde")]
     fn deserialize_tx_receipt_op() {
         // OtherFields for Optimism
         #[derive(Debug, serde::Deserialize)]
@@ -88,7 +86,6 @@ mod test {
     }
 
     #[test]
-    #[cfg(feature = "serde")]
     fn deserialize_tx_receipt_arb() {
         // OtherFields for Arbitrum
         #[derive(Debug, serde::Deserialize)]