rpc: add ExtendedTransaction type
#1317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
|
this type is on it's way out anyway paradigmxyz/reth#9774 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reth, we have quite a few places in the code where we are using
WithOtherFields<Transaction>and this is quite cumbersome to manipulate and a little bit long to write/read.https://github.com/paradigmxyz/reth/blob/05f862af41e74319ba00a1254d3a74192d304cce/crates/rpc/rpc/src/txpool.rs#L34
As a consequence an
ExtendedTransactioncould be useful for easier manipulations.