fix: ensure max_fee_per_blob_gas field handles Some(0) gracefully
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
changed the title
max_fee_per_blob_gas field handles Some(0) gracefully
zerosnacks
commented
Sep 27, 2024
| // Nothing to fill if non-eip4844 tx or `max_fee_per_blob_gas` is already set to a valid | ||
| // value. | ||
| if tx.blob_sidecar().is_none() | ||
| || tx.max_fee_per_blob_gas().is_some_and(|gas| gas >= BLOB_TX_MIN_BLOB_GASPRICE) |
There was a problem hiding this comment.
If the field is set to Some(0) (which happens because of serialization) we force setting it to .next_block_blob_fee() as 0 is always invalid as it is less than BLOB_TX_MIN_BLOB_GASPRICE (1).
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
zerosnacks
commented
Sep 27, 2024
Comment on lines
+317
to
+319
| to: Some(address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045").into()), | ||
| sidecar: Some(sidecar), | ||
| ..Default::default() |
There was a problem hiding this comment.
Tests both cases, implicit Some(0) / None and explicit Some(0)
mattsse
approved these changes
Sep 27, 2024
It is but it mostly enables you do not define the field and rely on the filler. What happens is that the transaction is serialized as 0 as the field is required. This is then interpreted as |
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
…alloy-rs#1389) * max_fee_per_blob_gas with Some(0) will always fail because it is below BLOB_TX_MIN_BLOB_GASPRICE (1) * add basic EIP-4844 test without defining max_fee_per_blob_gas * test both cases, explicit Some(0) and implicit Some(0) / None * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #1371
Solution
Related Foundry PR: foundry-rs/foundry#8963 that depends on this implementation
If
max_fee_per_blob_gasisSome(0)orNonewe set it to a valid valuenext_block_blob_fee().PR Checklist