Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure max_fee_per_blob_gas field handles Some(0) gracefully #1389

Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: ensure max_fee_per_blob_gas field handles Some(0) gracefully #1389

merged 4 commits into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. max_fee_per_blob_gas with Some(0) will always fail because it is belo… 

    …w BLOB_TX_MIN_BLOB_GASPRICE (1)
    @zerosnacks
    zerosnacks committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cd9f247 View commit details
    Browse the repository at this point in the history

  2. add basic EIP-4844 test without defining max_fee_per_blob_gas

    @zerosnacks
    zerosnacks committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c3c266d View commit details
    Browse the repository at this point in the history

  3. test both cases, explicit Some(0) and implicit Some(0) / None

    @zerosnacks
    zerosnacks committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c551138 View commit details
    Browse the repository at this point in the history

  4. fix clippy

    @zerosnacks
    zerosnacks committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3318c9f View commit details
    Browse the repository at this point in the history