chore(consensus): less derives for bincode compatible types #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/bincode-compat-less-derives
branch
from
a8a6b88
to
91a1444
Compare
shekhirin
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
approved these changes
Sep 30, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
…#1401) * chore(consensus): less derives for bincode compatible types * less derives on doctests too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small cleanup after #1397. Changing the field names is non-breaking because bincode doesn't store any metadata for fields, including their names.