Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: do not limit feature powerset check by depth #1406

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ci: do not limit feature powerset check by depth #1406

wants to merge 4 commits into from

Conversation

shekhirin
Copy link
Contributor

@shekhirin shekhirin commented Oct 1, 2024 •
edited
Loading

Motivation

Help us to catch errors like 9eb1409

Solution

Check full feature powerset without limiting by depth for alloy-consensus, alloy-eips and alloy-genesis crates.

@shekhirin shekhirin added the meta Changes in the contributor workflow and planning label Oct 1, 2024
@DaniPopes
Copy link
Member

That's not even gonna compute because it goes OOM lol

@DaniPopes
Copy link
Member

Depth 2 is ok but could take too long

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane will be requested when the pull request is marked ready for review emhane is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
meta Changes in the contributor workflow and planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @DaniPopes