Various Subscription improvements #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Feb 1, 2024
prestwich
force-pushed
the
prestwich/sub-buffer-size-config
branch
from
5d2f9ed
to
f7b6b0d
Compare
DaniPopes
reviewed
Feb 1, 2024
prestwich
changed the title
prestwich
changed the title
onbjerg
requested changes
Feb 2, 2024
mattsse
approved these changes
Feb 5, 2024
Comment on lines
+28
to
+32
| /// Indicates that the request is a non-standard subscription (i.e. not | ||
| /// "eth_subscribe"). | ||
| pub fn set_is_subscription(&mut self) { | ||
| self.is_subscription = true; | ||
| } |
There was a problem hiding this comment.
this could use some helper functions to:
set sub state with bool arg
Comment on lines
+64
to
+67
| /// "eth_subscribe"). | ||
| pub fn set_is_subscription(&mut self) { | ||
| self.meta.set_is_subscription() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #170
Solution
PubSubFrontendthat allows setting the default subscription channel size limitPR Checklist