Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conversion TxKind -> Option<Address> #750

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Add conversion TxKind -> Option<Address> #750

merged 5 commits into from
Sep 28, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 26, 2024

Motivation

Required for interfacing between alloy_consensus::Transaction and alloy_network_primitives::TransactionResponse

Solution

Implements conversion From<TxKind> for Option<Address>

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this is reasonable

@DaniPopes DaniPopes merged commit 0cd3a72 into main Sep 28, 2024
29 checks passed
@DaniPopes DaniPopes deleted the emhane/convert-tx-kind branch September 28, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emhane @mattsse @DaniPopes