Adding fee computation functions to l1BlockInfoTx

[cody-wang-cb]

Motivation

We want to reuse op-alloy's block info type in revm, but it's missing some fee computation functions. Thus this PR aims to add these functionalities.

Solution

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[cody-wang-cb]

Hey @clabby, I just updated the PR to include a new module with the fee calculation functions, PTAL again

One question (related to #134 (comment)):
Should L1BlockInfoTx enums still implement method calculate_tx_l1_cost and call those functions? One thing I’m still not sure about is the edge case around the first block for ecotone needs to use calculate_tx_l1_cost_bedrock calculation, which requires l1_fee_overhead. So in order to implement calculate_tx_l1_cost for L1BlockInfoTxEcotone it seems like it must add this attribute?

[clabby]

One thing I’m still not sure about is the edge case around the first block for ecotone needs to use calculate_tx_l1_cost_bedrock calculation, which requires l1_fee_overhead. So in order to implement calculate_tx_l1_cost for L1BlockInfoTxEcotone it seems like it must add this attribute?

I think they should not. The consumer can decide to handle this case; i.e. in revm, we'll check if there's empty scalars like we do today, and then choose which of these functions we use as a result.

[cody-wang-cb]

@clabby just addressed the comments and all the checks passed now, PTAL again

[refcell]

This is looking good to me pending @clabby's review

[emhane]

lgtm, would be nice if you can open an issue to use these to integrate/replace equivalent logic in reth_optimism_evm::l1