port: from reth-trie-common to alloy-trie
#53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Oct 14, 2024
Comment on lines
+32
to
+34
| alloy-consensus = { version = "0.3.6", default-features = false } | ||
| alloy-genesis = { version = "0.3.6", default-features = false } | ||
|
|
There was a problem hiding this comment.
we can't use any of this because this introduces cyclical deps
|
we can introduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves all the code from reth/crates/trie/common/ (not just the trie root logic) to alloy-trie, as discussed in issue #11211. The idea is to have all the trie-related functionality in one place within the alloy-trie crate.
The project compiles smoothly with the reth crate added in Cargo.toml, and I haven't run into any circular dependency issues. That said, I want to ensure this aligns with the direction you're heading.
Question
Does this approach fit with what you have in mind? Also, is the plan for reth to start using all this functionality from alloy-trie moving forward?