Allow configurable page source in AllureSelenide #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yaroslav-orel
force-pushed
the
config-page-source
branch
from
803db1f
to
df89f35
Compare
yaroslav-orel
force-pushed
the
config-page-source
branch
from
df89f35
to
c5d9c55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I need to be able to configure page source for attachments in AllureSelenide. I use appium for automation of native mobile applications. On getPageSource() request Appium returns XML tree by default (and it can also be configured to return JSON), not HTML like Selenium WebDriver. So when my XML is treated as HTML, attachment is not displayed in Allure. It's just blank (because of source type mismatch).
So my pull request fixes this issue. By default HTML source type is implied but client can configure it to their needs using
configureSource()method.Checklist