Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing withdraw modal updates and adding info #886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IanWoodard
Copy link
Collaborator

Removed refetching for balance result data as it would often conflict with the max withdrawable data which would make things complicated. I chose to remove it rather than try to make it work as a constantly flowing stream of data makes keeping the form up to date while not messing with the user's input very complex. Moreover, I find it annoying when my balances are constantly changing, especially when trying to withdraw everything. I know there are some workaround we could try, but unless there are clear drawbacks to this approach, I feel it would be better to keep it simple. Additionally, I added a callout if the user is limited in how much they can withdraw due to utilization. To determine if the user is limited, I took a similar approach to the isConstrainedByUtilization by checking the withdrawablePercentage.
image

Base automatically changed from iw/fix-includes to master September 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant