Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different features dir #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow different features dir #93

wants to merge 2 commits into from

Conversation

jricardo27
Copy link

Allow to specify an alternative features directory

Useful when for some unfortunate reason there is already a directory called features.

Useful when for some unfortunate reason there is already a
directory called features.
@@ -2,7 +2,7 @@
Setup script.
"""

__version__ = '0.0.44'
__version__ = '0.0.45'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this, releases are independent of pull requests.

@koterpillar
Copy link
Member

What's the rationale for this? With this change, the steps cannot be shared between features and that creates confusion.

Remember that you can always run a part of the features by passing features/main or features/alternative to aloe/harvest.

@koterpillar
Copy link
Member

If features is an existing module, you can still create, for example, gherkin_tests/features and put the features there.

I think not requiring the features directory be named features is a better approach, but need to think about how to discover steps in that case. Possible solution:

  • If it has feature files (and is a module), it is a feature directory.
  • Steps are loaded from every feature directory found.

@danni
Copy link
Contributor

danni commented Feb 3, 2016

I agree, I think in terms of Aloe you would just pass it to the command. However I think there's room for it in Aloe-Django as something to go in your settings file?

@koterpillar
Copy link
Member

Need to document what to do if you already have a module called features and you don't want to dump all the features there (solution: put them into gherkin_tests/features or similar).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants