Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to long-short.py to make it more Pythonic and beginner friendly #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on May 3, 2021

  1. Make changes to long-short.py to make it more Pythonic and beginner f…

    …riendly
    
    As an example, it was destructive for a beginner to the Python language. This does not change the core design which is still flawed, but it allows the code to run fully.
    
    Summary of changes:
    - 4 spaces instead of 2 (PEP8: https://www.python.org/dev/peps/pep-0008/)
    - camelCase to snake_case (PEP8)
    - Remove parentheses from if statements (PEP8)
    - Add some type hints where useful (syntax)
    - Avoid using un-imported pandas (pd) library to create timestamps, instead use proper datetime.date (syntax)
    - Remove all threading usage as it is all unnecessary when threads are immediately joined (design)
    - Remove all passing of lists to functions to retrieve values and instead use return statements for said values (design)
    - Add URL wrapping on API initialization to comply with the type hints of the library (misc)
    Sciguymjm committed May 3, 2021
    Configuration menu
    Copy the full SHA
    489818a View commit details
    Browse the repository at this point in the history