-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IEX plugin improvements #170
base: master
Are you sure you want to change the base?
Conversation
bd38c83
to
ec0dda5
Compare
Thanks for the interesting patch. I think there are use cases for this. But I don't think hard-coded list of symbol is suitable as a general purpose. Why don't you make it fully configurable to specify which symbols to filter? |
Sure, I will push the update soon |
Actually, now I am thinking that you can kind of filtering the symbols if you specify them in the configuration of the |
I agree it's better to specify high-level query term to make it dynamic set of symbols. |
@@ -0,0 +1,522 @@ | |||
package filter | |||
|
|||
// SPY is a function which indicates if the given symbols is within S&P500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// SPY is a function which indicates if the given symbols is within S&P500 | |
// SPY is a function which indicates if the given symbols are within S&P500 |
return false | ||
} | ||
|
||
// SPYSymbols is array symbols which are within S&P500 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// SPYSymbols is array symbols which are within S&P500 | |
// SPYSymbols is an array of symbols which are within S&P500 |
The PR includes 2 small changes:
SPY