refactor(metadata): avoid using sync.Once #498
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 47.75% 47.85% +0.09%
==========================================
Files 122 122
Lines 12236 12261 +25
==========================================
+ Hits 5843 5867 +24
+ Misses 5905 5903 -2
- Partials 488 491 +3
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
stop using sync.Once in metadata.go and lock by itself.
WHY
Do()function insync.Oncestruct doesn't allow to return value, which means the error in the function can't be handled.It causes unexpected result of the initialization of metadata.